[lkml]   [2012]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v3 1/9] string: introduce memweight
    On Fri, Jun 8, 2012 at 5:50 PM, Akinobu Mita <> wrote:
    >  lib/string.c           |   36 ++++++++++++++++++++++++++++++++++++

    Is lib/string.c the right place for this? I get a build error on the
    ia64 sim_defconfig:

    LD arch/ia64/hp/sim/boot/bootloader

    It fails because it pulls in lib/lib.a(string.o) to get some
    innocuous function like strcpy() ... but it also gets
    given memweight() which relies on __bitmap_weight()
    which it doesn't have, because it doesn't include lib/built-in.o
    (which is where bitmap.o, the definer of __bitmap_weight(), has
    been linked).

    Moving memweight() to lib/bitmap.c fixes the problem. But it
    isn't really clear that it belongs there either. Perhaps it should
    be its own file lib/memweight.c that gets included in lib/lib.a?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-06-21 02:01    [W:0.022 / U:31.968 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site