lkml.org 
[lkml]   [2012]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: boot: Remove ancient dead code
    On Thu, 21 Jun 2012, Paul Bolle wrote:

    > Release v1.3.82 wrapped a few lines of code in an "#ifdef
    > SAFE_RESET_DISK_CONTROLLER" and "#endif" pair. Since
    > SAFE_RESET_DISK_CONTROLLER was never defined anywhere that was basically
    > a verbose "#ifdef 0" and "#endif" pair. These dead lines have been in
    > the tree for sixteen years but now the time has come to remove them.
    >
    > I guess the main lesson here is that if you want your dead code in the
    > tree for a very long time you'd better be creative. A plain old "#ifdef
    > 0" and "#endif" pair just doesn't cut it!
    >
    > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
    > Link: https://lkml.org/lkml/1996/3/30/38
    > Cc: Jeff Epler <jepler@inetnebr.com>
    > ---
    > arch/x86/boot/header.S | 7 -------
    > 1 files changed, 0 insertions(+), 7 deletions(-)
    >
    > diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
    > index efe5acf..9b9c647 100644
    > --- a/arch/x86/boot/header.S
    > +++ b/arch/x86/boot/header.S
    > @@ -406,13 +406,6 @@ init_size: .long INIT_SIZE # kernel initialization size
    >
    > .section ".entrytext", "ax"
    > start_of_setup:
    > -#ifdef SAFE_RESET_DISK_CONTROLLER
    > -# Reset the disk controller.
    > - movw $0x0000, %ax # Reset disk controller
    > - movb $0x80, %dl # All disks
    > - int $0x13
    > -#endif
    > -
    > # Force %es = %ds
    > movw %ds, %ax
    > movw %ax, %es
    >
    Looks good to me.
    Not that I have much knowledge of the code, but I did dig the history a
    bit and yes, this looks like long dead stuff that should just go away.

    Acked-by: Jesper Juhl <jj@chaosbits.net>


    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-06-21 01:01    [W:0.053 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site