Messages in this thread | | | From | Axel Lin <> | Date | Wed, 20 Jun 2012 15:08:06 +0800 | Subject | Re: [PATCH v2] regulator: max77686: Implement .set_ramp_delay() callback. |
| |
2012/6/20 Yadwinder Singh Brar <yadi.brar01@gmail.com>: > This patch implements the .set_ramp_delay callback to set the ramp_delay on > hardware for BUCK2/3/4 if ramp_delay is set in regulator constraints. > > This patch also do some cleaning work for unrequired members of > struct max77686_data. > > Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com> > --- > drivers/regulator/max77686.c | 37 +++++++++++++++++++++++++++++-------- > 1 files changed, 29 insertions(+), 8 deletions(-) > > diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c > index a29eee3..5c2a32f 100644 > --- a/drivers/regulator/max77686.c > +++ b/drivers/regulator/max77686.c > @@ -65,11 +65,34 @@ enum max77686_ramp_rate { > }; > > struct max77686_data { > - struct device *dev; > - struct max77686_dev *iodev; > struct regulator_dev **rdev; > }; > > +static int max77686_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) > +{ > + unsigned int ramp_value = RAMP_RATE_NO_CTRL; > + > + switch (ramp_delay) { > + case 1 ... 13750: > + ramp_value = RAMP_RATE_13P75MV; > + break; > + case 13751 ... 27500: > + ramp_value = RAMP_RATE_27P5MV; > + break; > + case 27501 ... 55000: > + ramp_value = RAMP_RATE_55MV; > + break; > + case 55001 ... 100000: > + break; > + default: > + pr_warn("%s: ramp_delay: %d not supported, setting 100000\n", > + rdev->desc->name, ramp_delay); Hi Yadwinder, I'm a bit confused about this default setting. If set_ramp_delay() is not called, the default setting for BUCK234 is MAX77686_DVS_RAMP_DELAY (27500 uV/uS). So why you set default to 100000 here.
Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |