Messages in this thread | | | Date | Wed, 20 Jun 2012 13:47:03 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH 12/12] Avoid dereferencing bd_disk during swap_entry_free for network storage |
| |
On 06/20/2012 05:38 AM, Mel Gorman wrote: > Commit [b3a27d: swap: Add swap slot free callback to > block_device_operations] dereferences p->bdev->bd_disk but this is a > NULL dereference if using swap-over-NFS. This patch checks SWP_BLKDEV > on the swap_info_struct before dereferencing. > > With reference to this callback, Christoph Hellwig stated "Please > just remove the callback entirely. It has no user outside the staging > tree and was added clearly against the rules for that staging tree". > This would also be my preference but there was not an obvious way of > keeping zram in staging/ happy. > > Signed-off-by: Xiaotian Feng<dfeng@redhat.com> > Signed-off-by: Mel Gorman<mgorman@suse.de>
Acked-by: Rik van Riel<riel@redhat.com>
| |