lkml.org 
[lkml]   [2012]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] x86, microcode: Make reload interface per system
    On Wed, Jun 20, 2012 at 01:28:57AM +0200, Borislav Petkov wrote:
    > But you're right, reordering the registration could simplify the code.
    > I'll take a look at it tomorrow.

    Actually, IINM, the code doesn't become simpler - just different because
    if sysfs_create_group() fails, then you have to do microcode_dev_exit().
    Pasting here the whole snippet:

    ...
    error = microcode_dev_init();
    if (error)
    goto out_driver;

    error = sysfs_create_group(&cpu_subsys.dev_root->kobj,
    &cpu_root_microcode_group);

    if (error) {
    pr_err("Error creating microcode group!\n");
    goto out_dev_misc; <--- we need to undo what microcode_dev_init() did here...
    }

    register_syscore_ops(&mc_syscore_ops);
    register_hotcpu_notifier(&mc_cpu_notifier);

    pr_info("Microcode Update Driver: v" MICROCODE_VERSION
    " <tigran@aivazian.fsnet.co.uk>, Peter Oruba\n");

    return 0;

    out_dev_misc:
    microcode_dev_exit(); <--- and we do it here

    out_driver:
    ...

    Now, if we get to remove the crappy misc dev interface, then we can
    simplify the whole thing. But for that I need a statement from Intel
    people how they want to load ucode and whether they want to split the
    firmware blob or keep it together and load the whole 1.2MB at once.

    So I'll keep the error unwind as it was in the original patch.

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    GM: Alberto Bozzo
    Reg: Dornach, Landkreis Muenchen
    HRB Nr. 43632 WEEE Registernr: 129 19551


    \
     
     \ /
      Last update: 2012-06-20 15:41    [W:0.023 / U:61.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site