Messages in this thread |  | | | Date | Sat, 2 Jun 2012 17:16:02 +0200 | | From | Sam Ravnborg <> | | Subject | Re: [PATCH 01/27] smpboot: Provide a generic method to boot secondary processors |
| |
On Sat, Jun 02, 2012 at 04:11:28AM +0530, Srivatsa S. Bhat wrote: > On 06/01/2012 10:23 PM, Sam Ravnborg wrote: > > >> + > >> + > >> +/* Implement the following functions in your architecture, as appropriate. */ > >> + > >> +/** > >> + * __cpu_pre_starting() > >> + * > >> + * Implement whatever you need to do before the CPU_STARTING notifiers are > >> + * invoked. Note that the CPU_STARTING callbacks run *on* the cpu that is > >> + * coming up. So that cpu better be prepared! IOW, implement all the early > >> + * boot/init code for the cpu here. And do NOT enable interrupts. > >> + */ > >> +#ifndef __cpu_pre_starting > >> +void __weak __cpu_pre_starting(void *arg) {} > >> +#endif > > > > I miss the prototype for this in a header? > > > Prototype is not really necessary for this. Hence not added. There is a simple rule: 1) If a function is declared => not static 2) If function not declared => static
With respect to this simple rule your functions shall be defined as static. And that would not work.
Sam
|  |