Messages in this thread |  | | | Date | Tue, 19 Jun 2012 18:25:41 -0700 | | From | Anton Vorontsov <> | | Subject | Re: [PATCH] thermal: Constify 'type' argument for the registration routine |
| |
On Tue, Jun 19, 2012 at 05:11:28PM -0700, Andrew Morton wrote: > On Sun, 17 Jun 2012 21:50:37 -0700 > Anton Vorontsov <anton.vorontsov@linaro.org> wrote: > > > thermal_zone_device_register() does not modify 'type' argument, so > > it is safe to declare it as const. Otherwise, if we pass a const > > string, we are getting the ugly warning: > > > > ... > > > > For some reason I can't apply this.
The reason is the same patch in ACPI tree that "broke" battery tree; we're just touching the same lines of code and that causes some pain.
> I typed it in again and it seems > to work OK. I'll assume that someone else will merge it into > whatever-tree-broke.
Len, will you merge this patch? Or should I take it into battery tree? (If I'm taking it, then Stephen will have to resolve some conflicts upon next -next tree generation.)
> > +struct thermal_zone_device * > > +thermal_zone_device_register(const char *, int, void *, > > const struct thermal_zone_device_ops *, int tc1, int tc2, > > int passive_freq, int polling_freq); > > void thermal_zone_device_unregister(struct thermal_zone_device *); > > Personally, I prefer it when the arguments are named in the declaration > - if you ever have reason to *read* the thing, the lack of names is > quite maddening. Particularly when the function has 72 arguments.
:-)
-- Anton Vorontsov Email: cbouatmailru@gmail.com
|  |