lkml.org 
[lkml]   [2012]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] video: exynos_dp: fix build warning due to uninitialized value
    Date

    On Wed, June 20, 2012 at 9:46 AM, Florian Tobias Schandinat wrote:

    > Hi Jingoo,
    >
    > On 06/19/2012 06:36 AM, Jingoo Han wrote:
    > > This patch fixes build warning due to uninitialized value dereference.
    > > @@ -407,6 +407,8 @@ static unsigned int exynos_dp_get_lane_link_training(
    > > case 3:
    > > reg = exynos_dp_get_lane3_link_training(dp);
    > > break;
    > > + default:
    > > + return -EINVAL;
    >
    > Why do you consider returning -EINVAL here a good idea? As far as I can
    > see the caller does not check the return value for an error condition
    > and I doubt that the hardware understands what -EINVAL means. If you
    > want to fix the warning, make sure that you don't hide actual errors,
    > add an WARN or BUG or make sure the error code makes it to userspace.
    >

    OK, I will fix it and send the v2 patch.
    Thank you.

    Best regards,
    Jingoo Han




    \
     
     \ /
      Last update: 2012-06-20 03:21    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean