lkml.org 
[lkml]   [2012]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2/2] x86, microcode: Make reload interface per system
On Tue, Jun 19, 2012 at 11:10:14PM +0000, Yu, Fenghua wrote:
> > static int __init microcode_init(void)
> > {
> > struct cpuinfo_x86 *c = &cpu_data(0);
> > @@ -559,9 +568,17 @@ static int __init microcode_init(void)
> > if (error)
> > goto out_pdev;
> >
> > + error = sysfs_create_group(&cpu_subsys.dev_root->kobj,
> > + &cpu_root_microcode_group);
> > +
> > + if (error) {
> > + pr_err("Error creating microcode group!\n");
> > + goto out_driver;
> > + }
> > +
> > error = microcode_dev_init();
> > if (error)
> > - goto out_driver;
> > + goto out_ucode_group;
> >
> If you put sysfs_create_group() after microcode_dev_init(),
> out_ucode_group is unnecessary and code is a bit simpler.
> Microcode_dev_init() doesn't rely on sysfs_create_group() and it's a
> NULL function any way.

I don't think microcode_dev_init() is a NULL function since it depends
on CONFIG_MICROCODE_OLD_INTERFACE and we have it on by default:

config MICROCODE_OLD_INTERFACE
def_bool y
depends on MICROCODE

which makes me wonder whether we still need that OLD INTERFACE.
Henrique, any thoughts here?

But you're right, reordering the registration could simplify the code.
I'll take a look at it tomorrow.

Thanks.

--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551


\
 
 \ /
  Last update: 2012-06-20 02:21    [W:0.751 / U:0.120 seconds]
©2003-2014 Jasper Spaans. Advertise on this site