Messages in this thread Patch in this message | | | Date | Tue, 19 Jun 2012 21:47:27 +0200 | From | Oleg Nesterov <> | Subject | [PATCH 3/5] uprobes: kill write_opcode()->lock_page(new_page) |
| |
write_opcode() does lock_page(new_page) for no reason. Nobody can see this page until __replace_page() exposes it under ptl lock, and we do nothing with this page after pte_unmap_unlock().
If nothing else, the similar code in do_wp_page() doesn't lock the new page for page_add_new_anon_rmap/set_pte_at_notify.
Signed-off-by: Oleg Nesterov <oleg@redhat.com> --- kernel/events/uprobes.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 5b10705..16a3b69 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -238,9 +238,7 @@ retry: if (ret) goto unlock_out; - lock_page(new_page); ret = __replace_page(vma, vaddr, old_page, new_page); - unlock_page(new_page); unlock_out: unlock_page(old_page); -- 1.5.5.1
| |