Messages in this thread | | | Date | Tue, 19 Jun 2012 11:39:05 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH V2 1/3] regulator: dt: regulator match by regulator-compatible |
| |
On 06/19/2012 08:28 AM, Laxman Dewangan wrote: > Match the device's regulators with the property of > "regulator-compatible" of each regulator node.
> diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
> /** > - * of_regulator_match - extract regulator init data > + * of_regulator_match - extract regulator init data when node > + * property "regulator-compatible" matches with the regulator name. > * @dev: device requesting the data > * @node: parent device node of the regulators > * @matches: match table for the regulators > * @num_matches: number of entries in match table > * > * This function uses a match table specified by the regulator driver and > - * looks up the corresponding init data in the device tree. Note that the > - * match table is modified in place. > + * looks up the corresponding init data in the device tree if > + * regulator-compatible matches. Note that the match table is modified > + * in place. > * > * Returns the number of matches found or a negative error code on failure. > */
I don't think you actually need to modify any of the documentation; the function is still doing the exact same thing and it's an implementation detail really that it's doing it based on the regulator-compatible property rather than the node name now.
Still, that's just a nit-pick, so I'm OK either way.
> @@ -110,27 +112,39 @@ int of_regulator_match(struct device *dev, struct device_node *node, ... > + for_each_child_of_node(node, child) { ... > + for (i = 0; i < num_matches; i++) { ... > + match->of_node = child; > + count++;
You may as well "break;" here to avoid checking all the other match table entries, which hopefully don't have duplicate names...
But, that's also pretty minor, so: Acked-by: Stephen Warren <swarren@wwwdotorg.org>
| |