Messages in this thread | | | Date | Tue, 19 Jun 2012 15:04:00 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 1/2] regulator: support for regulator match by regulator-compatible |
| |
On Tuesday 19 June 2012 03:02 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, Jun 19, 2012 at 11:21:26AM +0530, Laxman Dewangan wrote: >> Add API to match the chip regulator's id by the >> property of "regulator-compatible" on regulator node. > We shouldn't have two different methods for doing this, we should > standardise this over all regulator drivers (or at the very least those > using the existing framework code) - having the old framework in place > will at best be confusing for authors of new drivers. We either need to > make it clear which framework to use or (ideally) remove the old > framework.
Agree. Currently following regulators are using this (based on grep) mfd/tps6586x.c regulator/ab8500.c regulator/db8500-prcmu.c and regulator/tps65910.
If the related change in tps65910 is fine and there is no more concern/feedback on the approach then I can create a series of patch to modify the other regulator and related dts file to follow the same.
If you want, I can make the new changes as part of this series or can start with new series.
I like to go with new series patch for other change once this is accepted.
| |