Messages in this thread | | | Date | Mon, 18 Jun 2012 15:42:53 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH UPDATED] block: In blk_execute_rq_nowait, init rq->end_io before checking for dead queue. |
| |
On Mon, Jun 11, 2012 at 02:23:23PM -0700, Muthu Kumar wrote: > On Mon, Jun 11, 2012 at 10:33 AM, Muthu Kumar <muthu.lkml@gmail.com> wrote: > > On Sun, Jun 10, 2012 at 10:40 AM, Bart Van Assche <bvanassche@acm.org> wrote: > >> On 06/09/12 23:57, Muthu Kumar wrote: > >> > >>> Locking change is the one you posted already (the link above). Anyway, > >>> I have the attached patch *including* the locking change. Original > >>> mail has attachment without locking change. Please use whatever you > >>> need. > >> > >> > >> While we are at it ... the rq->rq_disk and rq->end_io assignments can be > >> performed safely before the spinlock is taken, isn't it ? > >> > > > > Yes.. that spinlock is to protect the q. > > > > Attached patch with assignment performed before taking the spinlock.
This looks correct to me. Bart, can you please include this patch in your series and repost the series?
Thank you.
-- tejun
| |