lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 09/12] libata: tell scsi layer device supports runtime power off
    Date
    From: Aaron Lu <aaron.lu@amd.com>

    If ATA device supports "Device Attention", then tell scsi layer that
    the device supports runtime power off.

    Signed-off-by: Aaron Lu <aaron.lu@amd.com>
    Signed-off-by: Lin Ming <ming.m.lin@intel.com>
    ---
    drivers/ata/libata-acpi.c | 32 ++++++++++++++++++++++++++++----
    include/scsi/scsi_device.h | 1 +
    2 files changed, 29 insertions(+), 4 deletions(-)

    diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
    index 9287593..0c54d1e 100644
    --- a/drivers/ata/libata-acpi.c
    +++ b/drivers/ata/libata-acpi.c
    @@ -1000,7 +1000,10 @@ static void ata_acpi_add_pm_notifier(struct ata_device *dev)
    return;

    status = acpi_bus_get_device(handle, &acpi_dev);
    - if (ACPI_SUCCESS(status)) {
    + if (ACPI_FAILURE(status))
    + return;
    +
    + if (dev->sdev->can_power_off) {
    acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
    ata_acpi_wake_dev, dev);
    device_set_run_wake(&dev->sdev->sdev_gendev, true);
    @@ -1018,7 +1021,10 @@ static void ata_acpi_remove_pm_notifier(struct ata_device *dev)
    return;

    status = acpi_bus_get_device(handle, &acpi_dev);
    - if (ACPI_SUCCESS(status)) {
    + if (ACPI_FAILURE(status))
    + return;
    +
    + if (dev->sdev->can_power_off) {
    device_set_run_wake(&dev->sdev->sdev_gendev, false);
    acpi_remove_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
    ata_acpi_wake_dev);
    @@ -1102,10 +1108,13 @@ static int ata_acpi_bind_host(struct device *dev, int host, acpi_handle *handle)
    static int ata_acpi_bind_device(struct device *dev, int channel, int id,
    acpi_handle *handle)
    {
    - struct device *host = dev->parent->parent;
    - struct Scsi_Host *shost = dev_to_shost(host);
    + struct scsi_device *sdev = to_scsi_device(dev);
    + struct Scsi_Host *shost = sdev->host;
    struct ata_port *ap = ata_shost_to_port(shost);
    struct ata_device *ata_dev;
    + acpi_status status;
    + struct acpi_device *acpi_dev;
    + struct acpi_device_power_state *states;

    if (ap->flags & ATA_FLAG_ACPI_SATA)
    ata_dev = &ap->link.device[channel];
    @@ -1117,6 +1126,21 @@ static int ata_acpi_bind_device(struct device *dev, int channel, int id,
    if (!*handle)
    return -ENODEV;

    + status = acpi_bus_get_device(*handle, &acpi_dev);
    + if (ACPI_FAILURE(status))
    + return 0;
    +
    + /*
    + * If firmware has _PS3 or _PR3 for this device,
    + * and this ata ODD device support device attention,
    + * it means this device can be powered off
    + */
    + states = acpi_dev->power.states;
    + if ((states[ACPI_STATE_D3_HOT].flags.valid ||
    + states[ACPI_STATE_D3_COLD].flags.explicit_set) &&
    + ata_dev->flags & ATA_DFLAG_DA)
    + sdev->can_power_off = 1;
    +
    return 0;
    }

    diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
    index 6efb2e1..1237fac 100644
    --- a/include/scsi/scsi_device.h
    +++ b/include/scsi/scsi_device.h
    @@ -152,6 +152,7 @@ struct scsi_device {
    unsigned no_read_disc_info:1; /* Avoid READ_DISC_INFO cmds */
    unsigned no_read_capacity_16:1; /* Avoid READ_CAPACITY_16 cmds */
    unsigned is_visible:1; /* is the device visible in sysfs */
    + unsigned can_power_off:1; /* Device supports runtime power off */

    DECLARE_BITMAP(supported_events, SDEV_EVT_MAXBITS); /* supported events */
    struct list_head event_list; /* asserted events */
    --
    1.7.10


    \
     
     \ /
      Last update: 2012-06-18 09:21    [W:3.885 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site