Messages in this thread | | | From | "Tc, Jenny" <> | Subject | RE: [PATCHv2] power_supply: Register battery as a thermal zone | Date | Mon, 18 Jun 2012 05:10:57 +0000 |
| |
Hi Anton,
> -----Original Message----- > From: Anton Vorontsov [mailto:cbouatmailru@gmail.com] > Sent: Monday, June 18, 2012 9:59 AM > To: Tc, Jenny > Cc: linux-kernel@vger.kernel.org; R, Durgadoss > Subject: Re: [PATCHv2] power_supply: Register battery as a thermal zone > > On Wed, May 09, 2012 at 08:36:47PM +0530, Jenny TC wrote: > > Battery and charger contribute to Thermals in most of the embedded > > devices. So, it makes sense to identify them as Thermal zones in a > > particular platform. > > > > This patch registers a thermal zone if the power supply is reporting a > > temperature property. The thermal zone will be used by platform's > > thermal management solution. > > > > Signed-off-by: Jenny TC <jenny.tc@intel.com> > > --- > > Once again, thanks for the patch! It's a nice feature. > > [...] > > @@ -206,6 +258,9 @@ int power_supply_register(struct device *parent, > struct power_supply *psy) > > goto success; > > > > create_triggers_failed: > > + if (psy->tzd) > > + thermal_zone_device_unregister(psy->tzd); > > This causes errors: > > CC drivers/power/pda_power.o > drivers/power/power_supply_core.c: In function ‘power_supply_register’: > drivers/power/power_supply_core.c:261:9: error: ‘struct power_supply’ has > no member named ‘tzd’ > drivers/power/power_supply_core.c:262:37: error: ‘struct power_supply’ > has no member named ‘tzd’ > make[2]: *** [drivers/power/power_supply_core.o] Error 1 > > I think we should just introduce unregister_thermal(). So, that's what I've > applied:
Sorry I missed it. Thanks for adding it. Hope you will merge it
-jtc
| |