Messages in this thread | | | Date | Mon, 18 Jun 2012 13:52:32 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic |
| |
On Mon, Jun 18, 2012 at 08:29:45PM +0900, Sangbeom Kim wrote:
> -struct sec_irq_data { > - int reg; > - int mask; > +static struct sec_irq_data s2mps11_irqs[] = { > + [S2MPS11_IRQ_PWRONF] = { > + .reg = 1, > + .mask = S2MPS11_IRQ_PWRONF_MASK, > + },
This looks like you should be able to factor this code out into regmap_irq? Might be worth doing that first before all the renames so that adding the new PMIC would just be adding some more data. [unhandled content-type:application/pgp-signature] | |