lkml.org 
[lkml]   [2012]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] irqdomain: Support one-shot tear down of domain mappings.
Date
On Sat, 16 Jun 2012 07:34:03 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> On Fri, Jun 15, 2012 at 12:35:18PM -0600, Grant Likely wrote:
> > On Wed, 13 Jun 2012 16:34:01 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> > > +/**
> > > + * irq_domain_dispose_mappings() - Dispose of all mappings in a domain
> > > + * @domain: domain to tear down
> > > + */
> > > +void irq_domain_dispose_mappings(struct irq_domain *domain)
> > > +{
> > > + if (domain->revmap_type == IRQ_DOMAIN_MAP_NOMAP)
> > > + return;
> > > +
> > > + if (domain->linear_size) {
> > > + int i;
> > > +
> > > + for (i = 0; i < domain->linear_size; i++)
> > > + irq_dispose_mapping(domain->linear_revmap[i]);
> > > + } else {
> >
> > The 'else' should be dropped I think. With the merge of linear and
> > tree mappings into the same domain type, it is possible for a domain
> > to have both linear and tree mappings in the same instance. So tree
> > needs to be cleared even if linear_size is non-zero.
> >
> Ok, that's fine. Though by that same logic wouldn't it also be possible
> for a domain to have multiple linear ranges?

except that there is only one linear map. It would be possible to
have multiple maps, but I'm going to resist adding a whole lot of
options for reverse mapping to keep the lookup overhead low. A
sufficiently large linear map would also handle multiple linear maps.

g.



\
 
 \ /
  Last update: 2012-06-18 06:21    [W:1.034 / U:0.008 seconds]
©2003-2014 Jasper Spaans. Advertise on this site