Messages in this thread | | | Date | Sat, 16 Jun 2012 09:11:43 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/3] uprobes: write_opcode()->__replace_page() can race with try_to_unmap() |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> On 06/15, Ingo Molnar wrote: > > > > * Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote: > > > > > > @@ -228,9 +210,10 @@ static int write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, > > > > void *vaddr_old, *vaddr_new; > > > > struct vm_area_struct *vma; > > > > struct uprobe *uprobe; > > > > + unsigned long pgoff; > > > > loff_t addr; > > > > int ret; > > > > - > > > > +retry: > > > > > > Just a check on coding style: Shouldnt we have a preceeding blank > > > line before the goto label. > > > > Yeah, that's most likely helpful to readability. > > Aaah. Srikar, sorry, I didn't notice this comment and I already > sent 1-15. But I added the blank line in 2/15 ;) > > Ingo, please let me know if I need to re-diff and resend. > Otherwise I'll add the blank line later, write_opcode() needs > more changes anyway.
No need, I've added it before I committed the patch.
Thanks,
Ingo
| |