lkml.org 
[lkml]   [2012]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] extcon: Fix wrong index in max8997_extcon_cable[]
From
Nice catch!

Acked-by: Kyungmin Park <kyungmin.park@samsung.com>

On 6/16/12, Axel Lin <axel.lin@gmail.com> wrote:
> Currently, the index of "Dock-desk" and "Dock-card" are the same.
> Thus the latter one overrides the first one.
> Then we have problem when calling extcon_find_cable_index() because
> edev->supported_cable[7] only matches "Dock-card".
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/extcon/extcon-max8997.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c
> b/drivers/extcon/extcon-max8997.c
> index 23416e4..5ecf176 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -116,8 +116,8 @@ const char *max8997_extcon_cable[] = {
> [5] = "Charge-downstream",
> [6] = "MHL",
> [7] = "Dock-desk",
> - [7] = "Dock-card",
> - [8] = "JIG",
> + [8] = "Dock-card",
> + [9] = "JIG",
>
> NULL,
> };
> --
> 1.7.9.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


\
 
 \ /
  Last update: 2012-06-16 06:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site