lkml.org 
[lkml]   [2012]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/8] /proc/net/ entries for bluetooth protocols
From
Hi,

Thank you for reviewing.
I have a question.

>> + sk = sk_entry(v);
>> + bt = bt_sk(sk);
>> + seq_printf(seq, "%pK %-6d %-6u %-6u %-6u %-6lu",
>> + sk,
>> + atomic_read(&sk->sk_refcnt),
>> + sk_rmem_alloc_get(sk),
>> + sk_wmem_alloc_get(sk),
>> + sock_i_uid(sk),
>> + sock_i_ino(sk)
>> + );
>> + seq_puts(seq, batostr(&bt->src));
>
> batostr looks OK now but this will be outdated soon by %pMR.

As far as reading Documentation/printk-formats.txt and
pointer() in lib/vsprintf.c, %pMR is not defined.
I guess you mean %pM, don't you?

I've tried following code, and it works as expected.

baswap(&src_baswapped, &bt->src);
baswap(&dst_baswapped, &bt->dst);

seq_printf(seq, "%pK %-6d %-6u %-6u %-6u %-6lu %pM %pM %-6lu",
sk,
atomic_read(&sk->sk_refcnt),
sk_rmem_alloc_get(sk),
sk_wmem_alloc_get(sk),
sock_i_uid(sk),
sock_i_ino(sk),
&src_baswapped,
&dst_baswapped,
bt->parent? sock_i_ino(bt->parent): 0LU);


Masatake YAMATO


\
 
 \ /
  Last update: 2012-06-17 03:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site