lkml.org 
[lkml]   [2012]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH tip/core/rcu 14/14] rcu: Fix rcu_is_cpu_idle() #ifdef in TINY_RCU
    On Fri, Jun 15, 2012 at 03:57:49PM -0700, Paul E. McKenney wrote:
    > On Fri, Jun 15, 2012 at 02:28:28PM -0700, Josh Triplett wrote:
    > > On Fri, Jun 15, 2012 at 01:13:15PM -0700, Paul E. McKenney wrote:
    > > > From: "Paul E. McKenney" <paul.mckenney@linaro.org>
    > > >
    > > > The rcu_is_cpu_idle() function is used if CONFIG_DEBUG_LOCK_ALLOC,
    > > > but TINY_RCU defines it only when CONFIG_PROVE_RCU. This causes
    > > > build failures when CONFIG_DEBUG_LOCK_ALLOC=y but CONFIG_PROVE_RCU=n.
    > > > This commit therefore adjusts the #ifdefs for rcu_is_cpu_idle() so
    > > > that it is defined when CONFIG_DEBUG_LOCK_ALLOC=y.
    > > >
    > > > Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
    > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    > >
    > > Given that an earlier patch in this series makes rcupdate.h
    > > unconditionally prototype rcu_is_cpu_idle, shouldn't rcutiny.c define it
    > > unconditionally? (And do so before the earlier patch in this series
    > > makes it available unconditionally?)
    >
    > Or update that earlier patch so that it keeps rcu_is_cpu_idle() under
    > #ifdef CONFIG_DEBUG_LOCK_ALLOC. Either way, good catch!
    >
    > Hmmm... I want it under CONFIG_DEBUG_LOCK_ALLOC for TINY_RCU (memory
    > footprint and all that), but unconditional for TREE_RCU. That can
    > be arranged...

    Seems reasonable to me, as long as the availability of the prototype at
    compile time always matches the availability of the function at link
    time.

    - Josh Triplett


    \
     
     \ /
      Last update: 2012-06-16 01:41    [W:0.025 / U:0.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site