lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC 1/4] cpuidle: define the enter function in the driver structure
    Date
    Hi,

    On Fri, 8 Jun 2012 18:02:42 +0200, Daniel Lezcano wrote:
    > We have the state index passed as parameter to the 'enter' function.
    > Most of the drivers assign their 'enter' functions several times in
    > the cpuidle_state structure, as we have the index, we can delegate
    > to the driver to handle their own callback array.
    >
    > That will have the benefit of removing multiple lines of code in the
    > different drivers.
    >
    > In order to smoothly modify the driver, the 'enter' function are in
    > the driver structure and in the cpuidle state structure. That will
    > let the time to modify the different drivers one by one.
    > So the 'cpuidle_enter' function checks if the 'enter' callback is
    > assigned in the driver structure and use it, otherwise it invokes
    > the 'enter' assigned to the cpuidle_state.
    >
    > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    > ---
    > drivers/cpuidle/cpuidle.c | 4 +++-
    > include/linux/cpuidle.h | 1 +
    > 2 files changed, 4 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
    > index d90519c..155dee7 100644
    > --- a/drivers/cpuidle/cpuidle.c
    > +++ b/drivers/cpuidle/cpuidle.c
    > @@ -46,7 +46,9 @@ static inline int cpuidle_enter(struct cpuidle_device *dev,
    > struct cpuidle_driver *drv, int index)
    > {
    > struct cpuidle_state *target_state = &drv->states[index];
    > - return target_state->enter(dev, drv, index);
    > +
    > + return drv->enter(dev, drv, index) ? drv->enter(dev, drv, index) :

    Do you mean:
    drv->enter ? drv->enter(dev, drv, index) :
    ?

    Thanks,
    Namhyung


    > + target_state->enter(dev, drv, index);
    > }
    >
    > static inline int cpuidle_enter_tk(struct cpuidle_device *dev,
    > diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
    > index 6c26a3d..d82e169 100644
    > --- a/include/linux/cpuidle.h
    > +++ b/include/linux/cpuidle.h
    > @@ -130,6 +130,7 @@ struct cpuidle_driver {
    > struct cpuidle_state states[CPUIDLE_STATE_MAX];
    > int state_count;
    > int safe_state_index;
    > + int (*enter)(struct cpuidle_device *, struct cpuidle_driver *, int);
    > };
    >
    > #ifdef CONFIG_CPU_IDLE


    \
     
     \ /
      Last update: 2012-06-14 10:41    [W:0.024 / U:30.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site