lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] leds: use led_set_brightness in led_trigger_event
    Date
    Fix led_trigger_event() to use led_set_brightness() instead of
    __led_set_brightness(), so that any pending blink timer is stopped before
    setting the new brightness value. Without this fix LED status may be
    overridden by a pending timer.

    This allows a trigger to use a mix of led_trigger_event(),
    led_trigger_blink() and led_trigger_blink_oneshot() without races.

    (applied over: leds: Rename led_brightness_set() to led_set_brightness())

    Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>
    Cc: Shuah Khan <shuahkhan@gmail.com>
    Cc: Bryan Wu <bryan.wu@canonical.com>
    ---

    Hi Shuah,

    thanks for the renaming, looks much more clear now, so that's my
    led_trigger_event patch which applies on top of your latest patch - which
    should still be needed if I didn't lost anything.

    Fabio

    drivers/leds/led-triggers.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
    index 57721f2..de1c59d 100644
    --- a/drivers/leds/led-triggers.c
    +++ b/drivers/leds/led-triggers.c
    @@ -224,7 +224,7 @@ void led_trigger_event(struct led_trigger *trig,
    struct led_classdev *led_cdev;

    led_cdev = list_entry(entry, struct led_classdev, trig_list);
    - __led_set_brightness(led_cdev, brightness);
    + led_set_brightness(led_cdev, brightness);
    }
    read_unlock(&trig->leddev_list_lock);
    }
    --
    1.7.11.rc1.9.gf623ca1.dirty


    \
     
     \ /
      Last update: 2012-06-14 21:21    [W:0.022 / U:0.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site