Messages in this thread | | | Date | Thu, 14 Jun 2012 10:54:30 +0530 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [PATCH 5/6] uprobes: don't use loff_t for the valid virtual address |
| |
On Wed, Jun 13, 2012 at 08:51:06PM +0200, Oleg Nesterov wrote: > loff_t looks confusing when it is used for the virtual address. > Change map_info and install_breakpoint/remove_breakpoint paths > to use "unsigned long". > > The patch doesn't change vma_address(), it can't return "long" > because it is used to verify the mapping. But probably this > needs some cleanups too.
Oleg,
As you mentioned in another email, this conflicts with my [1/2] preparatory patch for the powerpc port. Do you think it just makes sense to make the arch_uprobe_analyze_insn() prototype change to take vaddr as part of this set itself?
I will then rebase the powerpc port when this goes into an upstream tree.
Ananth
| |