lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] x86: Track minimum microcode revision globally v2

* Andi Kleen <ak@linux.intel.com> wrote:

> On Wed, Jun 13, 2012 at 11:34:21PM +0200, Peter Zijlstra wrote:
> > On Wed, 2012-06-13 at 13:20 -0700, Andi Kleen wrote:
> > > + for_each_online_cpu (i)
> >
> > # git grep "for_each_[^(]*(" arch/x86/ | wc -l
> > 315
> > # git grep "for_each_[^(]* (" arch/x86/ | wc -l
> > 0
>
> Well, it's a for loop. Do you want me to grep for all for
> loops. We've never written for loops without space. Loops
> without space do not make any sense to me.

Good riddance, what Peter showed you is the standard Linux
kernel coding style:

$ git grep "for_each_[^(]*(" kernel/ | wc -l
758
$ git grep "for_each_[^(]* (" kernel/ | wc -l
0

... which standard style almost every single new patch of yours
continues to violate in some trivial way.

We are not going to allow you to mess up kernel code that we
maintain, so please address the review feedback you got from
Peter and don't submit such trivially flawed patches next time
around.

This is the fourth review round and counting, your stubborn
idiocy continues to waste reviewer and maintainer time.

> Anyways I'm changing it but under protest.

Be careful with holding back your breath for too long, it can do
permanent damage.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-06-14 11:41    [W:0.097 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site