lkml.org 
[lkml]   [2012]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging: comedi: pcl816: remove unneeded tests in pcl816_ai_cmdtest
    Date
    The step 2 tests of the start_src, scan_begin_src, and scan_end_src
    triggers to make sure they are unique are not needed. These triggers
    all only have one source and it was trivially validated in step 1.

    Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
    Cc: Ian Abbott <abbotti@mev.co.uk>
    Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/comedi/drivers/pcl816.c | 15 ---------------
    1 files changed, 0 insertions(+), 15 deletions(-)

    diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
    index c3ee6d6..ba6911f 100644
    --- a/drivers/staging/comedi/drivers/pcl816.c
    +++ b/drivers/staging/comedi/drivers/pcl816.c
    @@ -493,26 +493,11 @@ static int pcl816_ai_cmdtest(struct comedi_device *dev,
    * are unique and mutually compatible
    */

    - if (cmd->start_src != TRIG_NOW) {
    - cmd->start_src = TRIG_NOW;
    - err++;
    - }
    -
    - if (cmd->scan_begin_src != TRIG_FOLLOW) {
    - cmd->scan_begin_src = TRIG_FOLLOW;
    - err++;
    - }
    -
    if (cmd->convert_src != TRIG_EXT && cmd->convert_src != TRIG_TIMER) {
    cmd->convert_src = TRIG_TIMER;
    err++;
    }

    - if (cmd->scan_end_src != TRIG_COUNT) {
    - cmd->scan_end_src = TRIG_COUNT;
    - err++;
    - }
    -
    if (cmd->stop_src != TRIG_NONE && cmd->stop_src != TRIG_COUNT)
    err++;

    --
    1.7.7


    \
     
     \ /
      Last update: 2012-06-14 03:21    [W:0.024 / U:0.460 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site