Messages in this thread | | | Date | Wed, 13 Jun 2012 15:41:54 +0200 | Subject | Re: [PATCH 02/19] perf: Add ability to attach user level registers dump to sample | From | Stephane Eranian <> |
| |
On Wed, Jun 13, 2012 at 3:40 PM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > On Wed, 2012-06-13 at 15:18 +0200, Stephane Eranian wrote: >> >> If you look carefully at perf_output_sample(), you will notice that data is >> written in the exact order of the enum perf_event_sample_format. > > Not so actually.. CALLCHAIN is out of order. Not sure why we did that > though. > > > But it should match the comment near PERF_RECORD_SAMPLE.
Ok, yes that one. It would have been much nicer to follow the enum order.
| |