Messages in this thread | | | Date | Tue, 12 Jun 2012 15:52:18 -0700 (PDT) | Subject | Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit operation | From | David Miller <> |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr> Date: Tue, 12 Jun 2012 10:17:25 -0400 (EDT)
> From: Julia Lawall <Julia.Lawall@lip6.fr> > > IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false. The > value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so > first pick those bits and then make the test using !=. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thanks.
| |