lkml.org 
[lkml]   [2012]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 1/1] block: Add test-iosched scheduler
From

On Tue, June 12, 2012 7:09 am, Jeff Moyer wrote:
> Maya Erez <merez@codeaurora.org> writes:
>
>> The test scheduler allows testing a block device by dispatching
>> specific requests according to the test case and declare PASS/FAIL
>> according to the requests completion error code
>
> What sort of tests have you written that make use of this
> infrastructure?
>
>> @@ -1072,8 +1072,6 @@ struct request *blk_get_request(struct
>> request_queue *q, int rw, gfp_t gfp_mask)
>> {
>> struct request *rq;
>>
>> - BUG_ON(rw != READ && rw != WRITE);
>> -
>
> Please explain this.
get_request and get_request_wait, called by blk_get_request, expects to
get the REQ_SYNC flag in addition to the read/write flag. Moreover, it
uses the REQ_SYNC flag in its algorithm decision making.
However blk_get_request expects to get a Boolean to indicate only
read/write flag and cannot handle the REQ_SYNC flag.
>
> Cheers,
> Jeff
>


--
Sent by consultant of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum



\
 
 \ /
  Last update: 2012-06-13 00:04    [W:0.097 / U:0.396 seconds]
©2003-2014 Jasper Spaans. Advertise on this site