lkml.org 
[lkml]   [2012]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 8/8] staging: comedi: cleanup comedi_alloc_subdevices
On Tuesday, June 12, 2012 12:50 PM, Dan Carpenter wrote:
> On Tue, Jun 12, 2012 at 11:59:55AM -0700, H Hartley Sweeten wrote:
>> for (i = 0; i < num_subdevices; ++i) {
>> - dev->subdevices[i].device = dev;
>> - dev->subdevices[i].async_dma_dir = DMA_NONE;
>> - spin_lock_init(&dev->subdevices[i].spin_lock);
>> - dev->subdevices[i].minor = -1;
>> + s = dev->subdevices + i;
>
> You don't have to resend, but I think this would look better as:
>
> s = &dev->subdevices[i];

I don't disagree but the "dev->subdevices +i" format is consistently
used in all the comedi stuff. If the format above is preferred we
should probably update everything,

>> + s->device = dev;
>> + s->async_dma_dir = DMA_NONE;
>> + spin_lock_init(&s->spin_lock);
>> + s->minor = -1;
>> }
>
> Btw, this patchset is great. Nice.

Thanks!
Hartley


\
 
 \ /
  Last update: 2012-06-13 00:03    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site