Messages in this thread | | | Date | Tue, 12 Jun 2012 21:09:26 +0200 | Subject | Re: gma500: Cannot find any crtc or sizes - going 1024x768 | From | Patrik Jakobsson <> |
| |
On Tue, Jun 12, 2012 at 6:04 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: >> Was there a special reason for 0x4108 to be left out in the IS_MRST macro? >> To me it looks like the bitmask should have been updated in commit: >> >> gma500: Add the E6xx PCI identifier we are missing >> 56125db1eecf8d34d84f7925686110d90724edf0 >> >> If this is the case, I'll send a proper patch since this also applies to >> stable 3.3.x and 3.4.x > > Firstly it should never matter - there are no Moorestown devices in > circulation. E600T is very similar to Oaktrail. > > So the real question here seems to be why does the IS_MRST macro matter. > What weird firmware is involved here ?
It matters because everything between 0x4100 - 0x4107 are Moorestown if you ask the macro, but are assigned to oaktrail_chip_ops. That makes Oaktrail == Moorestown. IS_OAK might be a more appropriate name.
IS_MRST is primarily used for two things: 1) Take LVDS enable fuse value into account 2) Tell that LVDS must be on Pipe A
Those things where required for him to get the panel working, so why not include the 0x4108 in the IS_MRST check?
-Patrik
| |