Messages in this thread | | | Date | Tue, 12 Jun 2012 15:44:51 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 14/14] ARM: ux500: Move rtc-pl031 registration to Device Tree when enabled |
| |
On 12/06/12 15:32, Linus Walleij wrote: > On Tue, Jun 12, 2012 at 10:03 AM, Lee Jones<lee.jones@linaro.org> wrote: >> On 11/06/12 22:43, Linus Walleij wrote: > >>> Oh this is a bug fix really, well it's in the device tree so nevermind. >> >> It is? How so? > > That the device tree was declaring a compatible node for something > that never existed (stericsson,db8500-rtc) while the real node is > "arm,rtc-pl031", "arm,primecell". > > Without this fix 3.4 will not have an PL031 RTC I guess?
Think of the old entry as a dummy one, a stub if you will. Quite a few of the entries were initially loaded into the Device Tree as a best effort first attempt and had to be changed at a later date. This is no different. I see this as an enablement patch rather than a bug-fix. In fact, there would have been a bug if this worked when it was initially written, as the driver would have probed twice on a DT boot. Once by DT and once by platform code.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |