Messages in this thread |  | | | Date | Tue, 12 Jun 2012 16:46:32 +0200 | | From | Marc Kleine-Budde <> | | Subject | Re: [PATCH RFC] c_can_pci: generic module for c_can on PCI |
| |
On 06/12/2012 04:25 PM, Federico Vaga wrote: >>> +out_free_clock: >>> + if (!priv->priv) >> >> ^^^ >> >> looks fishy > > Also c_can_platform.c use priv->priv when it needs to get clk. I can add > a comment to specify what the statement do.
> +out_free_clock: > + if (!priv->priv) > + clk_put(priv->priv);
Why do you call clk_put on priv->priv, if priv->priv is NULL?
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [unhandled content-type:application/pgp-signature] |  |