lkml.org 
[lkml]   [2012]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit operation
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false. The
    value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so
    first pick those bits and then make the test using !=.

    This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    I hope to have fixed the mail client problem.

    diff --git a/drivers/ide/ide-cs.c b/drivers/ide/ide-cs.c
    index 28e344e..f1e922e 100644
    --- a/drivers/ide/ide-cs.c
    +++ b/drivers/ide/ide-cs.c
    @@ -167,7 +167,8 @@ static int pcmcia_check_one_config(struct pcmcia_device *pdev, void *priv_data)
    {
    int *is_kme = priv_data;

    - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {
    + if ((pdev->resource[0]->flags & IO_DATA_PATH_WIDTH)
    + != IO_DATA_PATH_WIDTH_8) {
    pdev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH;
    pdev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO;
    }

    \
     
     \ /
      Last update: 2012-06-12 17:01    [W:0.023 / U:62.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site