Messages in this thread |  | | | From | Namhyung Kim <> | | Subject | Re: [Perf bug-fix] check null of sym pointer before using it | | Date | Mon, 11 Jun 2012 13:45:17 +0900 |
| |
Hi,
On Mon, 11 Jun 2012 10:07:10 +0800, Shan Wei wrote: > ping..... > > It's a obvious function bug..... > > Shan Wei said, at 2012/6/5 13:14: > >> From: Samuel Liao <samuelliao@tencent.com> >> >> Sometimes, sym will be null that causing perf crash. >> >> Signed-off-by: Shan Wei <davidshan@tencent.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks for the fix. Namhyung
>> --- >> tools/perf/ui/browsers/annotate.c | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> >> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c >> index 4deea6a..50873a8 100644 >> --- a/tools/perf/ui/browsers/annotate.c >> +++ b/tools/perf/ui/browsers/annotate.c >> @@ -814,7 +814,7 @@ int symbol__tui_annotate(struct symbol *sym, struct map *map, int evidx, >> { >> struct disasm_line *pos, *n; >> struct annotation *notes; >> - const size_t size = symbol__size(sym); >> + size_t size; >> struct map_symbol ms = { >> .map = map, >> .sym = sym, >> @@ -834,6 +834,8 @@ int symbol__tui_annotate(struct symbol *sym, struct map *map, int evidx, >> if (sym == NULL) >> return -1; >> >> + size = symbol__size(sym); >> + >> if (map->dso->annotate_warned) >> return -1; >>
|  |