lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] staging: comedi: cleanup alloc_subdevices
On Monday, June 11, 2012 5:44 PM, Greg KH wrote:
> On Mon, Jun 11, 2012 at 07:07:41PM -0500, H Hartley Sweeten wrote:
>> 2, 3, and 4 probably go together. They all deal with the 'num_subdevices'
>>
>> 1 can be a separate patch as long as I don't do the rename.
>>
>> 5, 6, and 7 could all go together with the final rename of the function.
>>
>> Does that sound ok?
>
> No, why not just break it up into 7 different patches? You are doing
> different things, which would you rather review for correctness, 7
> simple, tiny patches, or some that do multiple things at the same time
> that are bigger?

Ok. I just posted the first one. It's still pretty big since it hits every
comedi driver file.

Please ignore the first post. I fat-fingered the prototype in the header.
v2 is correct.

Also, I have never done local commits to my Linux-next tree so I'm not
sure how to proceed with the incremental patches. If it's ok with you
I'll just wait for each patch to go into staging.

Regards,
Hartley



\
 
 \ /
  Last update: 2012-06-12 03:41    [W:0.090 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site