lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 1/3] mmc: core: Add packed command feature of eMMC4.5
From

> + if ((host->caps2 & MMC_CAP2_PACKED_CMD) &&
> + ((card->ext_csd.max_packed_writes > 0) ||
> + (card->ext_csd.max_packed_reads > 0))) {
> + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> + EXT_CSD_EXP_EVENTS_CTRL,
> + EXT_CSD_PACKED_EVENT_EN,
> + card->ext_csd.generic_cmd6_time);
> + if (err && err != -EBADMSG)
> + goto free_card;

Subhash suggestion to change to the following is missing:
if ( (host->caps2 & MMC_CAP2_PACKED_WR &&
card->ext_csd.max_packed_writes > 0) ||
(host->caps2 & MMC_CAP2_PACKED_RD &&
card->ext_csd.max_packed_reads > 0)
Thanks,
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum



\
 
 \ /
  Last update: 2012-06-11 23:02    [from the cache]
©2003-2011 Jasper Spaans