lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator
On Mon, Jun 11, 2012 at 08:01:20PM +0900, Jonghwa Lee wrote:

> v3
> - Add mutex to the max77686_clk structure to make atomic execution of enable/disable function.

No, you've not understood the issue. As I said on my previous review
these need to be prepare() and unprepare() since enable() and disable()
execute in atomic context - that means you can't do I2C I/O and you
can't take mutexes.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-06-11 14:04    [W:0.784 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site