lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] mx3fb: do not support panning with fb blanked
On Mon, Jun 11, 2012 at 09:06:48AM +0800, Liu Ying wrote:
> This patch checks if framebuffer is unblanked before
> we actually trigger panning in custom pan display
> function.
>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> drivers/video/mx3fb.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
> index e3406ab..d53db60 100644
> --- a/drivers/video/mx3fb.c
> +++ b/drivers/video/mx3fb.c
> @@ -1063,6 +1063,11 @@ static int mx3fb_pan_display(struct fb_var_screeninfo *var,
> dev_dbg(fbi->device, "%s [%c]\n", __func__,
> list_empty(&mx3_fbi->idmac_channel->queue) ? '-' : '+');
>
> + if (mx3_fbi->blank != FB_BLANK_UNBLANK) {
> + dev_dbg(fbi->device, "panning with fb blanked not supported\n");
> + return -EFAULT;
> + }

Why is this an error, and why return -EFAULT? What userspace access
failed?


\
 
 \ /
  Last update: 2012-06-11 12:41    [from the cache]
©2003-2011 Jasper Spaans