lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kthread: Implement park/unpark facility
On Sun, 10 Jun 2012, Rusty Russell wrote:

> On Tue, 5 Jun 2012 15:41:48 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> > Subject: kthread: Implement park/unpark facility
> > From: Thomas Gleixner <tglx@linutronix.de>
> > Date: Wed, 18 Apr 2012 16:37:40 +0200
> >
> > To avoid the full teardown/setup of per cpu kthreads in the case of
> > cpu hot(un)plug, provide a facility which allows to put the kthread
> > into a park position and unpark it when the cpu comes online again.
>
> Like the idea, but the API is awkward. Now you've made returning from a
> thread do different things depending on whether it was parked or not.
>
> How about just have the thread call "kthread_parkme()" which only
> returns if/when the thread is unparked?
>
> So the thread does:
>
> while (!kthread_should_stop()) {
> if (kthread_should_park()) {
> ... cleanup ...
> kthread_parkme();
> ... restore ...
> }
> ... work ...
> }
>
> Threads which never exit have "for (;;)" instead of while
> (!kthread_should_stop()).

Makes sense. Will have a go on that.

One other thing what I'm thinking about is to avoid the synchronous
parking mechanism, i.e. just tell the thread to park and check the
park state later before going further down.

Thanks,

tglx


\
 
 \ /
  Last update: 2012-06-11 12:01    [W:0.277 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site