Messages in this thread |  | | | Date | Sun, 10 Jun 2012 15:47:52 +0800 | | From | Fengguang Wu <> | | Subject | Re: [PATCH] page-writeback.c: fix update bandwidth time judgment error |
| |
> static void global_update_bandwidth(unsigned long thresh, > unsigned long dirty, > unsigned long now) > { > static DEFINE_SPINLOCK(dirty_lock); > static unsigned long update_time; > > /* > * check locklessly first to optimize away locking for the most time > */ > if (time_before(now, update_time + BANDWIDTH_INTERVAL)) > return; > > spin_lock(&dirty_lock); > if (time_after_eq(now, update_time + BANDWIDTH_INTERVAL)) { > update_dirty_limit(thresh, dirty); > update_time = now; > } > spin_unlock(&dirty_lock); > } > > So time_after_eq in global_update_bandwidth function should also change > to time_after, or just ignore this disunion?
Let's just ignore them. You are very careful and I like it. Please move on and keep up the good work!
Thanks, Fengguang
|  |