lkml.org 
[lkml]   [2012]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] prctl: pdeath_signal sent when parent thread (instead of parent process) dies
On 05/29, Filipe Brandenburger wrote:
>
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -806,7 +806,8 @@ static void forget_original_parent(struct task_struct *father)
> BUG_ON(t->ptrace);
> t->parent = t->real_parent;
> }
> - if (t->pdeath_signal)
> + if (t->pdeath_signal &&
> + !same_thread_group(father, reaper))
> group_send_sig_info(t->pdeath_signal,
> SEND_SIG_NOINFO, t);
> } while_each_thread(p, t);

Filipe, you can't even imagine how much do I like this change
personally ;) Although I think that pdeath_signal code should
be moved into reparent_leader(). I suggested this many times.

But I was told there are users which depend on current behaviour,
they really want to know when the parent _thread_ exits.

Why? I have no idea. And I agree this is ugly, but we can't
break user-space.

Oleg.



\
 
 \ /
  Last update: 2012-06-01 22:21    [W:0.193 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site