lkml.org 
[lkml]   [2012]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND PATCH 1/3] uprobes: Remove redundant lock_page/unlock_page
    On 06/01, Srikar Dronamraju wrote:
    >
    > @@ -315,12 +315,10 @@ static int read_opcode(struct mm_struct *mm, unsigned long vaddr, uprobe_opcode_
    > if (ret <= 0)
    > return ret;
    >
    > - lock_page(page);
    > vaddr_new = kmap_atomic(page);
    > vaddr &= ~PAGE_MASK;
    > memcpy(opcode, vaddr_new + vaddr, UPROBE_SWBP_INSN_SIZE);
    > kunmap_atomic(vaddr_new);
    > - unlock_page(page);

    Great, this lock_page() was really confusing.

    Oleg.



    \
     
     \ /
      Last update: 2012-06-01 21:21    [W:0.049 / U:0.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site