lkml.org 
[lkml]   [2012]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 00/13] net: Add and use ether_addr_equal
    From
    Date
    On Wed, 2012-05-09 at 21:21 -0400, David Miller wrote:
    > From: Joe Perches <joe@perches.com>
    > Date: Tue, 8 May 2012 21:56:44 -0700
    >
    > > Add a boolean function to test 2 ethernet addresses for equality
    > > Convert compare_ether_addr uses to ether_addr_equal
    >
    > This series looks great, I'll apply all of it.

    coccinelle is a nifty, better sed, tool. Thanks Julia et al.

    > That case you didn't convert in mac80211 is probably the
    > bug Johannes was talking about which started this whole
    > discussion.

    Looks like it.

    Do you want a similar patch/patches for drivers/net?

    If I break it out by nominal driver/maintainer,
    it'll be a highish number of low density patches.

    $ git grep -w compare_ether_addr drivers/net | wc -l
    59
    $ git grep -w -l compare_ether_addr drivers/net | wc -l
    31

    Maybe just a single patch?

    Also the compare_ether_addr_64bits function is
    still used a couple dozen times. Maybe another
    patch for those? ether_addr_equal_64bits?




    \
     
     \ /
      Last update: 2012-05-10 04:21    [W:0.027 / U:0.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site