lkml.org 
[lkml]   [2012]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] video: mb862xxfbdrv.c: local functions should not be exposed globally
    On 05/03/2012 12:37 AM, H Hartley Sweeten wrote:
    > Functions not referenced outside of a source file should be marked
    > static to prevent them from being exposed globally.
    >
    > Quiets the sparse warnings:
    >
    > warning: symbol 'mb862xx_intr' was not declared. Should it be static?
    >
    > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
    > Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
    > Cc: Anatolij Gustschin <agust@denx.de>

    Applied.


    Thanks,

    Florian Tobias Schandinat

    >
    > ---
    >
    > diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
    > index 11a7a33..00ce1f3 100644
    > --- a/drivers/video/mb862xx/mb862xxfbdrv.c
    > +++ b/drivers/video/mb862xx/mb862xxfbdrv.c
    > @@ -579,7 +579,7 @@ static ssize_t mb862xxfb_show_dispregs(struct device *dev,
    >
    > static DEVICE_ATTR(dispregs, 0444, mb862xxfb_show_dispregs, NULL);
    >
    > -irqreturn_t mb862xx_intr(int irq, void *dev_id)
    > +static irqreturn_t mb862xx_intr(int irq, void *dev_id)
    > {
    > struct mb862xxfb_par *par = (struct mb862xxfb_par *) dev_id;
    > unsigned long reg_ist, mask;
    >



    \
     
     \ /
      Last update: 2012-05-10 02:41    [W:0.051 / U:1.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site