lkml.org 
[lkml]   [2012]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v2] staging: comedi: remove __user annotation inside of struct's
On Wednesday, May 09, 2012 1:42 PM, Greg KH wrote:
> On Wed, May 09, 2012 at 09:36:03AM -0700, H Hartley Sweeten wrote:
>> Remove the __user annotations in the struct definitions in
>> comedi.h.
>>
>> These structs are used to pass information from user-space
>> to kernel-space. The copy_from_user and copy_to_user functions
>> are used to transfer the data between the address spaces.
>>
>> The drivers then use the information internally under the
>> assumption that they are kernel-space objects. Having the
>> __user annotations inside the structs produces a number of
>> sparse warnings of the type:
>>
>> warning: dereference of noderef expression
>>
>> According to Grek Kroah-Hartman:

Sorry about that typo... ;-)

>>
>> "When the kernel exports .h files, stuff like this should work
>> "automatically", so there is no need to not put __user markings."
>
> Wait, for some reason I thought you were adding __user markings, not
> removing them from the structures. That is why I said the above
> statement.

Ah.. Missed the "not" in your comment...

>
> Why again are you removing them? Didn't you just cause more sparse
> warnings to pop up?

I still think they should be removed but I need to dig thru it a bit.

The structs in question are used internally in the comedi drivers after
the data has been passed into the kernel using the various ioctl's.
The ioctl code does do the copy_from/to_user correctly (kind of,
I did notice one place where the copy_from_user is referencing a
kernel pointer). But, when the driver's try to use the data, assuming
it's kernel space data, it's still annotated as __user so we get all the
"warning: dereference of noderef expression" along with a couple
other sparse warnings.

Ian Abbott did reply that he thought the patch was correct. With my
miss-read of your comment I thought you were agreeing.

Regardless, I'll keep looking it over...

Regards,
Hartley


\
 
 \ /
  Last update: 2012-05-09 23:41    [from the cache]
©2003-2011 Jasper Spaans