lkml.org 
[lkml]   [2012]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5, resend] PCI: adjust quirk handler section annotations
    >>> On 09.05.12 at 18:08, Bjorn Helgaas <bhelgaas@google.com> wrote:
    > On Wed, May 9, 2012 at 9:02 AM, Jan Beulich <JBeulich@suse.com> wrote:
    >>>>> On 09.05.12 at 17:54, Bjorn Helgaas <bhelgaas@google.com> wrote:
    >>> My inclination is that all PCI fixups should work the same for
    >>> hot-added devices as for those present at boot, which would suggest
    >>> that we should always use __devinit, not __init. If I'm missing
    >>> something, please educate me :)
    >>
    >> That's certainly possible - I simply based the patch on what is there
    >> currently.
    >
    > Yep, your patch makes perfect sense considering the tree as it is
    > today. But if you agree with my sense of what it *should* be, I think
    > we should leave things as they are, or work on moving everything

    I indeed wondered why it isn't that way while doing this.

    > towards __devinit (I'd be thrilled if you wanted to work on that :)).
    > Otherwise we'd just be changing things to __init that we'd have to
    > change back later.

    I'd perhaps rather drop my patches then, as the main benefit
    (moving stuff from resident text to init text) would go away.

    Jan

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-09 19:21    [W:4.218 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site