Messages in this thread | | | Date | Wed, 9 May 2012 17:44:51 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v4] vsmp: Fix number of CPUs when vsmp is disabled |
| |
* Ido Yariv <ido@wizery.com> wrote:
> +static void __init vsmp_cap_cpus(void) > +{ > + void __iomem *address; > + unsigned int cfg, topology, node_shift, maxcpus; > + > +#ifdef CONFIG_X86_VSMP > + /* VSMP is enabled, no need to cap cpus */ > + return; > +#elif defined(CONFIG_SMP) > + /* > + * CONFIG_X86_VSMP is not configured, so limit the number CPUs to the
I suspect this will throw compiler warnings in the CONFIG_X86_VSMP && !CONFIG_SMP case.
Why not do something like:
static void __init vsmp_cap_cpus(void) { #if !defined(CONFIG_X86_VSMP) && defined(CONFIG_SMP) ... #endif }
This keeps the #ifdef complexity reasonably concentrated.
Thanks,
Ingo
| |