lkml.org 
[lkml]   [2012]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] vsmp: Fix number of CPUs when vsmp is disabled

* Ido Yariv <ido@wizery.com> wrote:

> +static void __init vsmp_cap_cpus(void)
> +{
> + void __iomem *address;
> + unsigned int cfg, topology, node_shift, maxcpus;
> +
> +#ifdef CONFIG_X86_VSMP
> + /* VSMP is enabled, no need to cap cpus */
> + return;
> +#elif defined(CONFIG_SMP)
> + /*
> + * CONFIG_X86_VSMP is not configured, so limit the number CPUs to the

I suspect this will throw compiler warnings in the
CONFIG_X86_VSMP && !CONFIG_SMP case.

Why not do something like:

static void __init vsmp_cap_cpus(void)
{
#if !defined(CONFIG_X86_VSMP) && defined(CONFIG_SMP)
...
#endif
}

This keeps the #ifdef complexity reasonably concentrated.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-05-09 18:22    [W:1.886 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site