Messages in this thread | | | Subject | Re: [RFC][PATCH] printk: Add %pb to print bitmaps | From | Peter Zijlstra <> | Date | Wed, 09 May 2012 16:24:17 +0200 |
| |
On Wed, 2012-05-09 at 16:15 +0200, Ingo Molnar wrote: > So, if someone specifies an incomplete "%pb" format - fmt[1] > will be 0 and we take precision as the length - presumably also > 0.
yes, printf_spec is initialized to 0s.
> We stick that 0 into: > > > + len = bitmap_scnlistprintf(buf, end - buf, ptr, bits); > > Will that work?
Yes, bitmap_scnlistprintf() will only set buf[0] = 0 (which will be overwritten by a possible next printf token) and return 0 length not advancing the ptr.
| |