lkml.org 
[lkml]   [2012]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] dynamic_debug: remove unneeded includes
    Hi Jim,

    On Thu, 3 May 2012 11:57:39 -0600 Jim Cromie <jim.cromie@gmail.com> wrote:
    >
    > These arent currently needed, so drop them. Some will probably get
    > re-added when static-branches are added, but include loops prevent
    > that at present.

    How sure are you that these are not needed? Has this been done by
    inspection, or by compile testing? How widely have you compile tested?

    I took a brief look ...

    >
    > Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    > ---
    > lib/dynamic_debug.c | 10 ----------
    > 1 files changed, 0 insertions(+), 10 deletions(-)
    >
    > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
    > index 7ca29a0..fc5d270 100644
    > --- a/lib/dynamic_debug.c
    > +++ b/lib/dynamic_debug.c
    > @@ -14,24 +14,14 @@
    >
    > #include <linux/kernel.h>
    > #include <linux/module.h>
    > -#include <linux/moduleparam.h>

    There is a use of module_param() in this file ...

    > -#include <linux/kallsyms.h>
    > -#include <linux/types.h>
    > #include <linux/mutex.h>
    > -#include <linux/proc_fs.h>
    > #include <linux/seq_file.h>
    > -#include <linux/list.h>

    List_for_each_entry is used ...

    > -#include <linux/sysctl.h>
    > #include <linux/ctype.h>
    > -#include <linux/string.h>

    strlen() is used ...

    > -#include <linux/uaccess.h>

    copy_from_user() is used ...

    > #include <linux/dynamic_debug.h>
    > #include <linux/debugfs.h>
    > #include <linux/slab.h>
    > -#include <linux/jump_label.h>
    > #include <linux/hardirq.h>
    > #include <linux/sched.h>
    > -#include <linux/device.h>

    struct device is referenced ...

    I am a bit more paranoid about these things than most.
    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-05-05 07:21    [W:0.027 / U:30.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site